up

1 files changed, 11 insertions, 8 deletions

diff --git a/.local/bin/linkview b/.local/bin/linkview
index bd3a7b1..d1464e0 100755
--- a/.local/bin/linkview
+++ b/.local/bin/linkview
@@ -69,7 +69,7 @@ sub play
 			'playing media',
 			'  playing <b>' . $article_name . '</b>'
 		);
-		if (system(TERMINAL_PATH, "-e", MPV_PATH, $url) != 0) {
+		if (system(MPV_PATH, $url) != 0) {
 			exec(
 				NOTIFYSEND_PATH,
 				'-u', 'critical',
@@ -87,6 +87,7 @@ sub img_pdf
 {
 	my ($url, $article_name, $key) = @_;
 	my $file_name;
+	my $new_file_name;
 	my $pid;
 	my $ret;
 	my $tmp;
@@ -145,23 +146,24 @@ sub img_pdf
 		my ($name, undef, $ext) = fileparse($file_name, qr/\.[^.]*/);
 		$ug = Data::UUID->new;
 		$uuid = $ug->create_str();
-		rename($file_name, $uuid . $ext);
-		$file_name = $uuid . $ext;
+		$ext =~ s/\?.*//;
+		$new_file_name = $uuid . $ext;
+		rename($file_name, $new_file_name) or die $!;
 		if ($key eq "img") {
-			$ret = system(IMGVIEW_PATH . " " . $file_name);
+			$ret = system(IMGVIEW_PATH . " " . $new_file_name);
 		}
 		else {
-			$ret = system(ZATHURA_PATH, $file_name);
+			$ret = system(ZATHURA_PATH, $new_file_name);
 		}
 		if ($ret != 0) {
 			system(
 				NOTIFYSEND_PATH,
 				'-u', 'critical',
 				'failed to open image',
-				'  failed to open file <b>/tmp/'. $file_name . '</b>'
+				'  failed to open file <b>/tmp/'. $new_file_name . '</b>'
 				);
 		}
-		unlink($file_name);
+		unlink($new_file_name);
 		return;
 	}
 	return;
@@ -512,11 +514,12 @@ sub linkview
 {
 	my $answer;
 
-	if (@ARGV == 0 || $ARGV[0] eq "") {
+	if (@ARGV == 0 || $ARGV[0] eq '') {
 		print STDERR "linkview: no URL\n";
 		exit 1;
 	}
 	$answer = fzf_prompt($ARGV[0]);
+	return unless exists $func_list{$answer};
 	$func_list{$answer}->($ARGV[0], $ARGV[1], $answer);
 	return;
 }